fix: copy_demo_nbs function package path #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 36 36
Lines 2412 2412
=======================================
Hits 2270 2270
Misses 142 142 ☔ View full report in Codecov by Sentry. |
KPostOffice
approved these changes
Oct 22, 2024
openshift-ci
bot
added
lgtm
Ygnas
approved these changes
Oct 22, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3c0008d
into
project-codeflare:main
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
Verification steps
SDK
Setup
Notebook server ODH/RHOAI/Local
git clone https://github.com/project-codeflare/codeflare-sdk.gitdemo-notebooksdirectory tosrc/codeflare_sdkpoetry buildpip install --force-reinstall dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whlTesting
Run
copy_demo_nbs()ensure that the demo notebooks spawnChecks